On Jun 30, 2009, at 4:23 PM, Nigel Kersten wrote:

>
> On Tue, Jun 30, 2009 at 2:02 PM, Luke Kanies<[email protected]> wrote:
>>
>> On Jun 30, 2009, at 3:57 PM, Brice Figureau wrote:
>>
>>>
>>> Hi,
>>>
>>> I don't know if it's the heat wave in France or anything else, but I
>>> have one more proposal.
>>>
>>> This afternoon I was handing idle in #puppet and got distracted by
>>> someone (sorry I can't remeber the nickname) who was saying
>>> storedconfigs ruined their compile performance, etc... (you know the
>>> song).
>>>
>>> My only (current) usage of storedconfigs is for exported/collected
>>> resources. I don't care about the non-exported resources.
>>>
>>> So my idea was to transform the --storedconfig boolean in a flag
>>> taking
>>> 3 values: false, true, and exported.
>>> When running in the exported mode, the rails code would only store
>>> exported resources and that's it. Since there are way less exported
>>> resources than normal resources it shouldn't degrade the performance
>>> for
>>> people wanting only exported/collected resources.
>>>
>>> Of course those wanting the full resource list won't get any speed
>>> benefits.
>>>
>>> I can't imagine we didn't think about this before, so I feel like  
>>> I'm
>>> missing something obvious :-)
>>
>> That seems pretty reasonable, although I'd recommend an additional
>> option, since people are used to using --storeconfigs, and switching
>> this to a non-boolean option will cause the automatic integration  
>> with
>> getopt to fail (as you likely know).
>
> I'd like to suggest extending this feature so you can choose to only
> store facts as well, and given that, it probably makes sense to allow
> you to choose whether or not nodes are stored.
>
> So maybe a multi-valued setting that allows you to choose what subset
> of facts, nodes, exported resources and non-exported resources you
> wish to store?

Given where the time is being spent, you could safely store all of the  
node and fact information with almost no overhead.  If you want this  
information, then just include it every time, rather than making it  
more complex by adding further options that have a miniscule affect on  
time.

Really, if we just skipped the tags we'd be pretty good on time. :/

-- 
Now and then an innocent man is sent to the legislature.
     --Kin Hubbard
---------------------------------------------------------------------
Luke Kanies | http://reductivelabs.com | http://madstop.com


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to