Looking at it more closely, the reason the bug dissappeared was because the url changed from "/production/file_metadatas/modules/ bootloader/scripts?links=manage&ignore=.svn&&recurse=true" to "/ production/file_metadatas/modules/bootloader/scripts? links=manage&recurse=true&ignore=.svn&". The first inserts a nil in the params on the server, but the second doesn't. So the client bug is still there, it just happens to not be excersizing the server bug because the order changed.
On Jul 2, 12:54 pm, Jordan Curzon <[email protected]> wrote: > I was able to reproduce the bug several times and found the bug on the > server, and then the client randomly stopped sending the bad url. The > puppet configs and the source for the bug had been version controlled, > I have no clue what changed. > > Also, this particular bug was because the client was sending > parameters where both the key and the value. It might be a bug in the > client generating the parameters to send or it might be in converting > the parameters into a query string, ie inserting extra ampersands and > such. > > On Jul 2, 12:34 pm, Luke Kanies <[email protected]> wrote: > > > On Jul 2, 2009, at 7:42 AM, Jordan Curzon wrote: > > > We are concerned about empty strings also. A query string with two > > > ampersands next two each other parses to empty strings in both the > > > key and the value. I'll submit a new patch. > > > Seems like we should handle this on both sides - the client shouldn't > > be sending empty arguments, and the server should be able to handle > > empty arguments. > > > Any idea which arguments are being sent empty? --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
