On 5/07/09 18:08, Jordan Curzon wrote: > > > On Jul 5, 3:47 am, Brice Figureau <[email protected]> > wrote: >>> I like the idea of using proper mime types in the Content-Type >>> headers, Hopefully we can get the server responses to send proper mime >>> types too. >> It already does, AFAIK. > > set_content_type(response, "yaml") > ..... > format = format_to_use(request) > set_content_type(response, format) > > def set_content_type(response, format) > response.header['Content-Type'] = format > > #format_to_use returns the puppet format names, not mime/types. We > might want to abstract setting the content_type with a method that > finds the format to use, finds the mime time, sets the content_type to > the mime type and returns the format to use as a puppet format name. > That same code is currently repeated in each http/handler.rb do_* > method.
Yes, I noticed that after I sent my e-mail. I fixed this in the v2 and v3 of the patch. Now we correctly send the format mime-type. -- Brice Figureau My Blog: http://www.masterzen.fr/ --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
