On Fri, 2009-07-24 at 00:56 -0700, Luke Kanies wrote: > On Jul 24, 2009, at 12:52 AM, Brice Figureau wrote: > > > > > On Thu, 2009-07-23 at 16:07 -0700, Luke Kanies wrote: > >> Signed-off-by: Luke Kanies <[email protected]> > >> --- > >> lib/puppet/indirector/rest.rb | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/lib/puppet/indirector/rest.rb b/lib/puppet/indirector/ > >> rest.rb > >> index 909be9a..4d818c9 100644 > >> --- a/lib/puppet/indirector/rest.rb > >> +++ b/lib/puppet/indirector/rest.rb > >> @@ -49,7 +49,7 @@ class Puppet::Indirector::REST < > >> Puppet::Indirector::Terminus > >> end > >> else > >> # Raise the http error if we didn't get a 'success' of > >> some kind. > >> - message = "Server returned %s: %s" % [response.code, > >> response.message] > >> + message = "Error %s on SERVER: %s" % [response.code, > >> response.message] > >> raise Net::HTTPError.new(message, response) > > > > Why not add an indication that the server is the puppetmaster (when it > > is)? > > > > Why not add another message giving tips on where to look for a more > > complete error? > > My point is the following: > > if you get an error, the clueless user/newbie doesn't know how to get > > more information. So my idea was to add a message like this at the end > > of the current message. > > > > "This error originated on the Puppetmaster. To troubleshoot it or > > report > > a bug, you should run the master with --debug and/or --trace." > > > > Maybe what worries me in fact, is that most people think that using > > --debug --trace on the client is enough. But all what they'll get is > > the > > client side trace which ends up as not being useful at all. > > > > The perfect fix for my issue, would be when --debug or --trace are > > specified on the client, then those options are sent to the server and > > used for this connection. > > > > But other than that, I'd say +1. > > Why not submit that as a patch? :)
Yes, I had about the same patch as yours, which I never submitted for about no reason (beside forgetting about it). But my suggestion of modifying the debug/trace status of a sole client in the master from the client is much more complex than just modifying the error message, so I think it will have to wait. Or you might have a clever idea on how to do that :-) I remember James entered a usability ticket a couple of month ago with some good ideas on this subject. /me will read it again. > Really, I just wanted to get something out there to get movement on > this ticket. The poor usability here is my fault, and I despair a bit > of being the person to fix it. But it looked like something simple > enough that I could at least give it a push in hopes someone else > would see an even better way. OK, I'll send something over the week-end, then will compare. -- Brice Figureau My Blog: http://www.masterzen.fr/ --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
