On Jul 27, 2009, at 8:04 AM, Steven Jenkins wrote: > > Brice Figureau wrote: >> On Mon, 2009-07-27 at 08:04 +1000, James Turnbull wrote: >>> Brice Figureau wrote: >>>> Hi, >>>> >>>> James wanted to merge this patch for 0.25 (although I'm myself >>>> not sure >>>> it is a good idea), so I'm posting a new version fixing all bugs >>>> I could find and takig into account the various comments I >>>> received. >>> In my defence, I did say I'd be happy to see it bumped to 0.26.0 >>> if you >>> thought it too much trouble or a bridge too far. >>> >>> I am happy to have Luke et al weigh into the debate though. >>> >>> I will say though that the regex node directives are going to be a >>> big >>> plus for a lot of people. >>> >> >> I shortened too much the discussion we had with James, but indeed he >> said it was up to you Luke for the final decision. >> >> I'm myself somewhat undecided, because: >> * this is new stuff appearing late in the release cycle (although I >> don't see it being a show-stopper, but who knows) >> >> * will there be anything excitingly new for 0.26 (provided its >> release >> cycle will be shorter than this one)? >> >> So, I trust the if/case/selector patch to be stable and good. But I'm >> not so sure about the node regex stuff. I'd be more confident if a >> few >> good will could test it. >> The code is in tickets/master/2033 in my github repository: >> http://github.com/masterzen/puppet/tree/tickets/master/2033 > > Disclaimer: I don't know what the goals are with respect to release > cycles, so > my comments are based on a 'get 0.25 done as soon as possible' > mindset. > > Would it be reasonable for this *not* go into 0.25 (which is almost > ready for > release) but instead go into 0.26, and that 0.26 *only* contain > this, the > transaction/event handling changes, and bug fixes.
I'm of mixed minds here. We've got *tons* in 0.25, and I think it's going to take people a while to digest it all, and I think we're going to have a painfully large collection of bugs filed with this new release. But the work is already done, and it's very little in the way of behaviour change, rather it's just behaviour addition. I think we'll have enough in 0.26, though, that that shouldn't be enough to hold it. So for me, the deciding line is if someone can take the time to run it through its paces and make sure it behaves well. If we can get a couple of people to demonstrate its stability, then we merge it, otherwise we hold it. -- It is better to sleep on things beforehand than lie awake about them afterward. -- Baltasar Gracian --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
