On Aug 9, 2009, at 10:31 PM, Andrew Shafer wrote:
>
>
>
> It'd be nice to have the commit title match the purpose of the commit,
> rather than just what it does. In this case, you're fixing a bug, so
> it'd be good to at least refer to the actual bug, rather than the
> implementation that fixes it.
>
> And please keep that title below 50 or so chars, as mentioned here:
>
> http://www.tpope.net/node/106
>
> Tim's post says 50 isn't a hard maximum (as opposed to the 72) and
> the title should be a 'short summary of changes', which is what I
> have.
Thus the 'or so' in my length limit.
>
> Are you saying that summary is too literal and you would prefer
> something like 'Get rid of annoying log message'?
Exactly.
> > + it "should return a sorted, comma delimited string when
> > called with Array" do
> > +
> > @property.prepare_is_for_comparison(["foo","bar"]).must == "bar,foo"
> > + end
> > + end
> > +
>
> It seems like this is essentially a private method and shouldn't
> actually be tested. Shouldn't you be able to test it thoroughly with
> just inputs to 'insync?'?
>
> Good point, you are right. I just didn't see that when I wrote it. I
> went don't a path trying to add :absent semantics to should, which
> is not private and I never made that connection once I switched to
> this strategy.
>
>
> > nil" do
> > - @property.insync?("foo") == true
> > + @property.insync?("foo").must == true
> > end
>
> These would produce better output as:
>
> @property.must be_insync("foo")
>
> that's better
--
The conception of two people living together for twenty-five years
without having a cross word suggests a lack of spirit only to be
admired in sheep. --Alan Patrick Herbert
---------------------------------------------------------------------
Luke Kanies | http://reductivelabs.com | http://madstop.com
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
