> These tests look to be redundant now, so if you can push a new fix > with them removed, +1 >
Removing tests is easy enough, but I want to understand your motive. I don't consider them redundant per se, as they definitely test different things. I'm familiar with the argument some people make that you shouldn't test private methods, which those test do, but that is not the only position. I resent the patch without the tests and updated the ticket. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
