-1 Other branches of this case statement run the value through munge_name() before storing it in @pattern, and that function splits on ".", resulting in an array. Thus the proposed change would leave @pattern sometimes a String and sometimes an Array thus (I suspect) just moving the problem around rather than fixing it.
I agree in general that what is there is goofy/wrong, but I'm not sold that this is an adequate fix. -- Markus On Thu, 2009-08-13 at 13:05 -0700, Nigel Kersten wrote: > > Signed-off-by: Nigel Kersten <[email protected]> > --- > lib/puppet/network/authstore.rb | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/puppet/network/authstore.rb b/lib/puppet/network/authstore.rb > index 306e1ba..14ddaaf 100755 > --- a/lib/puppet/network/authstore.rb > +++ b/lib/puppet/network/authstore.rb > @@ -331,7 +331,7 @@ module Puppet > unless value =~ /^[a-za-z0-9][-a-za-z0-...@]*$/ > raise AuthStoreError, "Invalid pattern %s" % > value > end > - @pattern = [value] > + @pattern = value > @length = nil # force an exact match > @name = :opaque > end -- Markus <[email protected]> --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
