2009/8/23 Paul Nasrat <[email protected]>:
>
> We already had code to do this that wasn't tested or being called.
>
> Adding a per interface network fact

>
> Signed-off-by: Paul Nasrat <[email protected]>
> ---
>  lib/facter/interfaces.rb |    2 +-
>  spec/unit/util/ip.rb     |   11 +++++++++++
>  2 files changed, 12 insertions(+), 1 deletions(-)
>
> diff --git a/lib/facter/interfaces.rb b/lib/facter/interfaces.rb
> index 1239215..ce76717 100644
> --- a/lib/facter/interfaces.rb
> +++ b/lib/facter/interfaces.rb
> @@ -22,7 +22,7 @@ Facter::Util::IP.get_interfaces.each do |interface|
>     # Make a fact for each detail of each interface.  Yay.
>     #   There's no point in confining these facts, since we wouldn't be able 
> to create
>     # them if we weren't running on a supported platform.
> -    %w{ipaddress macaddress netmask}.each do |label|
> +    %w{ipaddress macaddress netmask network}.each do |label|

This actually doesn't work as we already have network.rb that calls
this code directly.

I'll resubmit with just the missing test added.

Paul

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to