On Tue, 2009-09-15 at 15:16 -0700, Luke Kanies wrote: > I can't think of a better solution, but I'm not real stoked about > 'node_exists?' returning something other than a boolean.
Yes, I had the same question. But couldn't find a better name which didn't involve renaming all other call sites. I tried node_by_name or node_by_equality, but none where really satisfying either. > Do we have a general naming issue here? Should 'node' return straight > equality while 'match_node' (or some other new method) returns > equality or regex comparison? Yes, it looks better. I'm even wondering if the first version of the patch (before I rebased on top of loadedcode) wasn't using this distinction. I will resend a patch tonight. -- Brice Figureau My Blog: http://www.masterzen.fr/ --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
