On Sep 23, 2009, at 11:17 AM, Brice Figureau wrote: > > On 23/09/09 20:00, Luke Kanies wrote: >> On Sep 23, 2009, at 12:08 AM, Brice Figureau wrote: >> >>> On Tue, 2009-09-22 at 14:34 -0700, Luke Kanies wrote: >>>> On Sep 22, 2009, at 12:31 AM, Brice Figureau wrote: >>>> >>>>> On Tue, 2009-09-22 at 08:38 +0200, David Schmitt wrote: >>>>>> [email protected] wrote: >>>>>>> The idea is that x/y/z (chained division) is rarer than >>>>>>> regexp--in >>>>>>> part because nobody trusts My Dear Aunt Sally that far. >>>>>>> >>>>>>> So it gets rid of the problem that was originally discovered but >>>>>>> not the root cause Brice realised behind it.. >>>>>>> >>>>>>> As for context sensitivity, I'd favour positive (regular >>>>>>> expression can occur in specific places) to negative. >>>>>> +1. Or use perl's m// to denote a matching regexp. That would get >>>>>> rid of >>>>>> the ambiguity at the lexing level. >>>>> Unfortunately, not always: >>>>> >>>>> $var = $thisvarendswithm/4/4 >>>> That should lex fine -- the variable will lex, then the slash. >>> Yes, I realized that when reading David's e-mail. >>> >>> Would this change be possible for 0.25.1? >>> It breaks 0.25.0 backward compatibilities but solves the issue in a >>> perfect way. >> >> >> Given the ridiculous complexity we're looking at adding to work >> around >> this, making the lexer easier by adding the leading 'm' or whatever >> seems like a good step. A bit ugly lexically, but way easier to >> implement and will help us avoid more pain in the future. > > Definitely. > For which version^H^H^H^H codename do we plan the change?
Well, it's a bugfix that just happens to horribly break backward compatibility. But I'd say 0.25.1, because we're basically choosing between breaking compatibility with code in 0.24 (incorrectly lexing division) and 0.25 (changing the regex lexing). Thoughts? -- Anyone who considers arithmatical methods of producing random digits is, of course, in a state of sin. --John Von Neumann --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
