> > So what to you think of the Token#acceptable? approach? > > At first glance it looks fine. > I didn't had time for an extensive review of the patch, though. > Just I was surprised you didn't add any specific tests for the case that > matters, but you might have sent an early bird version of the patch. >
Yeah, that was just a sketch of the direction I think would be easier going. More to see if there were difficulties I wasn't expecting (there don't seem to be) and give people a chance to shoot it down if they see a fatal flaw in the approach. I'll resubmit it with tests & the new ticket number later today. -- Markus --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
