+1 Tests look adequate, appears to have caught the analogous cases, and its a minimal-change patch (which is good for 0.25.1 goal of fixes only).
My only (misplaced, as it tuns out) concern was: > def latest > output = dpkg_deb "--show", @resource[:source] > matches = /^(\S+)\t(\S+)$/.match(output).captures > - unless matches[0].match(@resource[:name]) > + unless matches[0].match( Regexp.escape(@resource[:name]) ) Where the matches[0] will also contain the "++"; a little poking in irb shows that in "string1".match "string2" and similar constructs ruby always turns the second string into a regular expression, never the first, so this is actually fine. -- Markus --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
