Brice Figureau wrote:
> On Fri, 2009-10-23 at 10:24 +0200, David Schmitt wrote:
>> Brice Figureau wrote:
>>> This is not the right fix, but more a hackish workaround.
>>> text = facts.render(format)
>>>
>>> - return {:facts_format => format, :facts => CGI.escape(text)}
>>> + return {:facts_format => :b64_zlib_yaml, :facts =>
>>> CGI.escape(text)}
>> The :facts don't need CGI.escape, don't they?
>
> They need it because base64 can generate a '+' character which in an URL
> will be transformed as a ' '. So we still escape those.
>
> I could have used the url safe base64 variant[1], but it meant more
> touched files, and there is no direct support in ruby.
>
> [1] http://www.ietf.org/rfc/rfc3548.txt
Ah. D'oh, I was confused about which part was encoded here. You're
right, that is only a very minor problem anyways.
Regards, DavidS
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
