On Oct 26, 2009, at 1:00 PM, John A. Barbuto wrote: > > On Sun, Oct 25, 2009 at 9:21 PM, Luke Kanies <[email protected]> wrote: >> >> There are actually about three places in the code that check for >> whether the cacrl setting is set to 'false', so I'm not quite sure >> this is the right fix. >> >> Can you give a bit more background on it, and on why you didn't >> change >> the other locations too? > > You're right, the patch should account for those other locations too. > > From looking at commit 1cfb0215, it appears it's not necessary to > disable the CRL anymore. So, I tried removing the code from puppetd > altogether and sure enough it works fine, without the problem > mentioned in #989. Also did the same for the other locations, and not > having any CA problems with webrick or passenger either. Certificate > revocation with puppetca works, and all related tests pass as well, > except for those that check for :cacrl == false. > > I'll submit a patch shortly. If there's still disagreement about it, > I think someone with more knowledge of the code than I should take > over.
Great. -- I don't deserve this award, but I have arthritis and I don't deserve that either. -- Jack Benny --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
