>>> +        if err and err != ''
>>> +            Facter.debug("#{code} printed \"#{err}\" to stderr")
>>>         end
>> I rethought this part: Maybe we should use warn to print the captured
>> stderr in debug Mode to stderr? So it would be more or less the same
>> behavior as before but only if we're in debug mode. But maybe printing
>> stderr to debug is also not that bad, but maybe I should join the  
>> array?
> 
> They're pretty similar, but I think I'd prefer 'warn' over 'debug',  
> given that we don't use debug that much in Facter.

fine, I'll do another round with warn and the tests from your other mail.

cheers pete

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to