On Nov 25, 2009, at 11:31 AM, Markus Roberts wrote:
> +1.
>
> If it's deemed too chatty I'd suggest a one liner like:
>
> debug: Puppet::FileServing::Metadata supports: {pson b64_zlib_yaml
> marshal yaml raw}; Using yaml
>
> but if no one objects to the volume (that is, if the objection was
> to the misleading semblance of severity sans context) the patch as
> submitted looks fine.
I think this single line is much better; three lines for every network
data type is too much. And really, who's the extra information for?
If a given format isn't supported for a given type, developers are the
only ones who can really do anything about that, right? Users only
need to know the what, not the why, IMO.
So I'd modify it to use something like the above line. And I'd be
comfortable using the short indirection name ('file_metadata') rather
than the class name.
--
Zeilinger's Fundamental Law:
There is no Fundamental Law.
---------------------------------------------------------------------
Luke Kanies | http://reductivelabs.com | http://madstop.com
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
