Looks reasonable to me as a first cut (and no worries about the ticket / dev-list ordering--most things wind up both places eventually, and the exact order isn't important).
A few thoughts/questions: * Is there any analog to this on other platforms? * Could the same thing be accomplished by cleverly naming the resource? * Am I correct in assuming that "all" is special to pkgadd? * Instead of: > - cmd << "-n" << @resource[:name] > > + if @resource[:pkginst] > + cmd << "-n" << @resource[:pkginst] > + else > + cmd << "-n" << @resource[:name] > + end > + I'd prefer: > - cmd << "-n" << @resource[:name] > - cmd << "-n" << (@resource[:pkginst] || @resource[:name]) Thoughts? -- Markus -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
