On Dec 3, 2009, at 7:00 PM, James Turnbull wrote: > Jesse Wolfe wrote: >> Disables the b64_zlib_yaml format if zlib cannot be loaded. >> >> There's two aspects of this patch that I find to be less than ideal: >> 1) FactHandler' format is still hard-coded to YAML rather than >> using facts.class.default_format > > That makes sense I guess. > >> 2) zlib library loading isn't using the 'feature' system > > This one - maybe this is stupid of me but why not? Isn't this > inconsistent with all the other libraries we require?
Yeah, it probably should. Even this selective loading isn't a complete solution, though, is it? What if the client side of the connection has zlib and the server doesn't? -- Love truth, and pardon error. -- Voltaire --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
