-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

> +     rrddestdir = Puppet[:rrddir]
> +     if (!File.directory?(rrddestdir))
> +         Dir.mkdir(rrddestdir)
> +     end
> +

this should rather be

Dir.mkdir(Puppet[:rrddir]) unless File.directory?(Puppet[:rrddir])

maybe with the temporal local variable, but it isn't much shorter than
using the config-hash.

for the rest I can't really talk, as I'm not familiar with the rrd code.

cheers pete
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksfZjsACgkQbwltcAfKi3+c0QCdHK798rToit2meCVIwPTuebO+
FyUAoJERZcrhr+J0ZvB4gKU7IdZfxfHz
=un37
-----END PGP SIGNATURE-----

--

You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.


Reply via email to