+1, though the "self.fail" is going to go to "fail" on the code smell pass.
On Mon, Dec 14, 2009 at 1:56 PM, Jesse Wolfe <[email protected]> wrote: > > Signed-off-by: Jesse Wolfe <[email protected]> > --- > lib/puppet/type/file.rb | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/puppet/type/file.rb b/lib/puppet/type/file.rb > index 26d8efc..2f5b5df 100644 > --- a/lib/puppet/type/file.rb > +++ b/lib/puppet/type/file.rb > @@ -147,7 +147,7 @@ module Puppet > resource[:recurselimit] = value > true > else > - raise ArgumentError, "Invalid recurse value %s" % > value.inspect > + self.fail "Invalid recurse value #{value.inspect}" > end > end > end > @@ -163,7 +163,7 @@ module Puppet > when Integer, Fixnum, Bignum; value > when /^\d+$/; Integer(value) > else > - raise ArgumentError, "Invalid recurselimit value %s" % > value.inspect > + self.fail "Invalid recurselimit value #{value.inspect}" > end > end > end > -- > 1.6.5 > > -- > > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
