On Dec 17, 2009, at 12:52 AM, Brice Figureau wrote:

> On Thu, 2009-12-17 at 09:50 +0100, Brice Figureau wrote:
>> On Wed, 2009-12-16 at 14:33 -0800, Luke Kanies wrote:
>>> These replace the yaml and file dirs,
>>> since in #1943 we're merging the file and yaml
>>> Terminus classes.
>>>
>>> Signed-off-by: Luke Kanies <[email protected]>
>>> ---
>>> lib/puppet/defaults.rb       |    4 ++++
>>> spec/integration/defaults.rb |    8 ++++++++
>>> 2 files changed, 12 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/lib/puppet/defaults.rb b/lib/puppet/defaults.rb
>>> index 590de83..3c9dbd1 100644
>>> --- a/lib/puppet/defaults.rb
>>> +++ b/lib/puppet/defaults.rb
>>> @@ -454,6 +454,8 @@ module Puppet
>>>         # it to be in the server section (#1138).
>>>         :yamldir => {:default => "$vardir/yaml", :owner =>  
>>> "service", :group => "service", :mode => "750",
>>>             :desc => "The directory in which YAML data is stored,  
>>> usually in a subdirectory."},
>>> +        :server_datadir => {:default => "$vardir/ 
>>> server_data", :owner => "$user", :group => "$user", :mode => "750",
>>
>> Shouldn't it be :owner=>"service", :group=>"service"?
>
> Please disregard this comment:
> Obviously I should read the rest of the patches before commenting :-(

That probably should have been squashed.  I think I did a rebase in  
the middle of the development, which resulted in this change.

-- 
To be pleased with one's limits is a wretched state.
     -- Johann Wolfgang von Goethe
---------------------------------------------------------------------
Luke Kanies | http://reductivelabs.com | http://madstop.com

--

You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.


Reply via email to