On Dec 17, 2009, at 11:30 AM, Markus Roberts wrote: > On Thu, Dec 17, 2009 at 11:15 AM, Luke Kanies <[email protected]> > wrote: >> +1, but I'd rather than git rm port.rb than fix anything in it. I >> thought I'd actually already done that. :/ > > *smile* I considered that, but it seemed beyond the scope of this > ticket.
I haven't replied to your previous response to me, but to be clear - the policy is not to mix this kind of change into a single *commit*, not a commit series. The 'fix it when you see it' policy should still apply, just try to keep it to a separate commit, even if it's small. I find it quite hard to follow a development chain when commits have multiple intents included. -- My definition of an expert in any field is a person who knows enough about what's really going on to be scared. -- P. J. Plauger --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
