> * Change installapp to add the app to the file list in dbfile (i.e.,
> read the list if it's there, add the app to the list if the app
> isn't there already, and write it out).
> * Add an uninstall which uses the list in the dbfile to determine
> what apps to remove and then deletes the dbfile.
I'm leery of this sort of statefulness.
> * Rename methods from (.*)pkgdmg to \1appdmg.
> * Change errors from self.fail to raising Puppet::Error
I'm not clear why this was done. It seems, in a way, a step backwards.
> + receipthash = YAML::load_file(dbfile)
> + receipthash["files"].each do |appname|
> + FileUtils.remove_entry_secure("#{$appdmg_target}/#{appname}")
> + unless $? == 0
> + raise Puppet::Error.new("App DMG could not remove
> \"#{$appdmg_target}/#{appname}\"")
> + end
Is $? really valid here?
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
