2010/1/10 Markus Roberts <mar...@reality.com>:
> The recent release of 0.25.2 contains a new method of handling communication
> with "exec"ed processes to support SELinux and improve performance on other
> OSes which, unfortunately, has a number of shortcomings:

Just had a quick scan through the patch and noticed:

> index 0000000..ac536fe
> --- /dev/null
> +++ b/spec/unit/exec_test_helper
> @@ -0,0 +1,45 @@
> +#!/usr/bin/env ruby
> +
> +require 'optparse'
> +options = OptionParser.new
> +options.on("--kill-me-withi SIGNAL",/USR[12]/) { |signal| $kill_me = signal }

Looks like a typo in the options --kill-me-withi vs usage:

> +                        task = 
> [File.dirname(__FILE__)+'/exec_test_helper','--kill-me-with','USR1','--called-by',$PID,'--repeat',n]

Running with both --kill-me-with and --kill-me-withi seem to "work",
but I'm assuming you meant the former

paul-nasrats-macbook:puppet pnasrat$ ./spec/unit/exec_test_helper
--kill-me-with USR1
./spec/unit/exec_test_helper:26: I don't believe you,  is   PID TTY
       TIME CMD. (RuntimeError)
paul-nasrats-macbook:puppet pnasrat$ vi spec/unit/exec_test_helper
paul-nasrats-macbook:puppet pnasrat$ ./spec/unit/exec_test_helper
--kill-me-withi USR1
./spec/unit/exec_test_helper:26: I don't believe you,  is   PID TTY
       TIME CMD. (RuntimeError)


Paul
-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to puppet-...@googlegroups.com.
To unsubscribe from this group, send email to 
puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.


Reply via email to