Jesse, On Jan 26, 10:02 am, Jesse Wolfe <[email protected]> wrote: > +0.75 ! I finally got a change to test this on an OpenSolaris box. It works > fine - there's just a few tweaks I'd like to see in the code: > > 1) Uninstall should probably be recursive ( -r ), on other providers "ensure > => absent" will remove dependent packages, because that's the default > behavior for most other package managers > > 2) the "Executing" debug message is redundant, commands are already output > to the debug log. I saw: > debug: Executing '/usr/bin/pkg list -H' > debug: Puppet::Type::Package::ProviderPkg: Executing '/usr/bin/pkg list -H' > > 3) it would be nice to have spec tests for #query() and self.parse_line() > > 4) unfortunately, Puppet still uses 4-space indentation. This patch is in > 2-space indentation. > thanks for the feedback, give this one a try then :) <http://github.com/pmenglund/puppet/commit/ 5beaf76b3b4dcd3b70ac587afb1a0d786a562325>
cheers, /Martin -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
