On 2 March 2010 18:52, Markus Roberts <mar...@reductivelabs.com> wrote:
>
>
> On Sun, Feb 28, 2010 at 5:52 AM, Paul Nasrat <pnas...@googlemail.com> wrote:
>>
>> This reverts commit 33fb7709404e706801683e6c47ab7a0a5a1884b1.
>>
>> This has broken master for some facts (eg OS X facts), it also breaks
>> facter
>> platform support on win32 as popen3 does not work there.
>
> Is there a ticket for the problem?
For the broken tests but not the win32 platform breakage, I noticed
that when I was resyncing/testing.
It's tickets/master/3080 on by github
*snip*
> Is this a straight reversion? If so, I don't see how the original code
> worked as "out" appears to be undefined
Yes - you're just getting mixed up in the context by the look, the
function in the final tree looks like:
out = nil
begin
out = %x{#{code}}.chomp
rescue => detail
$stderr.puts detail
return nil
end
if out == ""
return nil
else
return out
end
end
> and the "output" parameter is ignored. If it isn't a straight reversion,
> why? Further, where is this called in the revised code?
I just did a git revert,
> It appears you may want to just remove parse_output, rather than breaking it
> and removing the tests.
No I want to revert it completely due to the popen3 breaking Win32.
Paul
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-...@googlegroups.com.
To unsubscribe from this group, send email to
puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
