On Thu, Mar 11, 2010 at 2:54 AM, James Turnbull <[email protected]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 11/03/10 1:51 AM, Michael DeHaan wrote: >> No, I haven't. >> >> I'm curious as to feedback on the idea/implementation. >> >> Tests can be added. > > Mike > > Actually I tend to agree with Paul. We require tests for community > submissions. Everyone should eat the same dog food. Even I have > grumbled my way through RSpec for extreme beginners. :) > > I also think having tests is broader than just tests for tests sake. > > Regards > > James Turnbull
Well, from a C.S. perspective, it doesn't make a lot of sense, unless we have a larger framework for integration tests that actually do things with real nodes. By the time it was mocked up, there would be nothing left original to test. I'd welcome someone disproving me by writing some meaningful tests for this, though what we would add here would not be very useful as I can see it. This is a systemic problem in testing philosophy, and I've seen it occur in a lot of apps. You really need a functional test platform. If we moved to a plugin framework for datasources, /perhaps/ but that's severe overdesign for something as simple as this IMHO, and you'd still need a real integration test platform to test the filesystem, which requires (presently) stubbing out the node files in the confdir, which requires faking confdir, and lots of other internals. Rather than mocking all this out, this is a sign for a larger need for a network of test nodes, well beyond unit tests. That, of course, requires out of band tests to make sure things happen, independent of the system, and a network for it. The downside to this is that system is difficult for people to run themselves, though it could clearly create some VMs, but it will not be a short running test. --Michael -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
