On Mar 27, 2010, at 11:02 AM, Markus Roberts wrote:
OK, I read your code and tested it.
It doesn't behave like 0.25.x behaved for generated resources, so I
don't even think my patch for #3396 is needed at all.
One of the reason behind my changes in #3396 was that we triggered an
event per generated resource that was back propagated to those
resources
themselves producing a combinatory explosion in edge matching.
I wasn't able to reproduce this issue with luke:tickets/master/2759
(it
doesn't seem to generate those many events).
So, based on this, I think we should completely drop
brice:tickets/0.25.x/3396 from the testing branch.
I will comment #3396 out of the test series. Are we done with this
part then?
I guess so. I actually like Brice's code better than mine (that is, I
like the optimizations in SimpleGraph instead of EventManager), but
it's equivalent since there's only the one place where the method is
called.
--
This space intentionally has nothing but text explaining why this
space has nothing but text explaining that this space would otherwise
have been left blank, and would otherwise have been left blank.
---------------------------------------------------------------------
Luke Kanies -|- http://puppetlabs.com -|- +1(615)594-8199
--
You received this message because you are subscribed to the Google Groups "Puppet
Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
