This edition focused on cleaning up the sequence as a whole, since the
head of testing had gotten unusably buggy again.  The process was
complicated by a number of test indeterminacies that had crept in
(Jesse did a great job tracking down #3148, BTW) and we didn't get
everything, but head should be _much_ cleaner.

No new code, as no tickets for Rowlf were marked Ready for Testing
since last time.


Starting at 164f1ce85bad49c7e197deeb452828c94539e06e
testing (Branching off master) succeeded:
    *
    7483 examples, 0 failures, 40 pending
    662 tests, 5993 assertions, 58 failures, 15 errors
        15 more in /language/parser.rb (15 total)
        3 more in /language/scope.rb (3 total)
        40 more in /language/snippets.rb (40 total)
        1 more in /other/report.rb (1 total)
        1 more in /ral/providers/group.rb (1 total)
        1 more in /ral/providers/package.rb (1 total)
        2 more in /ral/providers/service/debian.rb (2 total)
        2 more in /ral/providers/user.rb (2 total)
        2 more in /ral/type/exec.rb (2 total)
        1 more in /ral/type/file.rb (1 total)
        2 more in /ral/type/resources.rb (2 total)
        3 more in /util/settings.rb (3 total)
jesse:ticket/0.25.x/3423  (Unit test fixes) succeeded:
    * 2b8125c Replace test/unit file write test with spec
    * 11379c0 Removing old test for service/debian provider
    * 000d37a Removing resources generate tests
    * 74f5167 Mock user in SUIDManager tests
    * 06deee7 Fix test using wrong Puppet util filesetting group
    * 6a148e2 Supressing warnings (not really failures) in test/unit
    7485 examples, 0 failures, 40 pending
    658 tests, 5971 assertions, 53 failures, 15 errors
        2 fewer in /ral/providers/service/debian.rb (0 total)
        1 more in /ral/providers/user.rb (3 total)
        1 fewer in /ral/type/file.rb (0 total)
        2 fewer in /ral/type/resources.rb (0 total)
        1 fewer in /util/settings.rb (2 total)
jesse:repairs/master/test-unit-tests (More unit test fixes) succeeded:
    * 5b2802c Typo in method call in test.
    * b19a044 Some tests were leaking state when the test failed
    7485 examples, 1 failure, 40 pending
        1 more in unit/type/schedule.rb (1 total)
    658 tests, 6053 assertions, 17 failures, 14 errors
        1 fewer in /language/scope.rb (2 total)
        36 fewer in /language/snippets.rb (4 total)
bkearney:ticket/0.25.x/3387 (Backslashes in augeas) succeeded:
    * a591f56 Handle path elements with ticks and spaces
    * d87b806 Unit tests for path changes
    * 17b0ca5 fixed a couple of typos
    7487 examples, 1 failure, 40 pending
    658 tests, 6056 assertions, 17 failures, 13 errors
        1 fewer in /ral/providers/user.rb (2 total)
luke:tickets/master/2759 (Events) succeeded:
    * 1a0264c Moving log destination code into separate files
    * c5a422e removing never-used code
    * 1533211 Switching transactions to callback-based events
    * 534764f Moving Parameter utility classes into separate files
    * 2dfd1d6 Moving Ensure property into separate file
    * 6aeb7f0 Random code cleanup
    * 0b15c65 Adding "type" instance method to enhance Demeterness
    * 3ca6c46 Cleaning up Event creation
    * 9769c8f Reorganizing Property class to match current style
    * 7f13f8f Moving event creation to the resource
    * 814baff Changing SimpleGraph.matching_edges to expect one event
    * 4fff59c Extracting event management into a separate class
    * 510b342 Adding tests for the 'report' log destination
    * 7bf8a5d Removing unused code and adding a couple of tests
    * 4c39ae1 Removing a redundant method in Report
    * 243793e Adding Transaction events to Transaction reports
    * 213e4ed removing extraneous comment
    * e13f57b Fixing file content logs
    * a515556 Failing in app/puppet if facts are not found
    * 6de4877 Correcting comments and making report timestamp internal
    * 603d270 Adding tests for "Logging" module
    * 0a0e289 Using Logging module in main Puppet module
    * 12b6e76 Refactoring the RAL interface to logging
    * 01caf40 Cleaning up the Log initialization code.
    * eaaf48b Refactoring the Change/Event/Property interface
    * d403c5b Solidifying the RAL/Event integration.
    * 490ce74 Removing last event collection transaction code
    * 5b1b383 Fixing File type indentation
    * 22c7b15 Adding first version of Resource::Status class
    * e437807 Adding Transaction::ResourceHarness class
    * f6bb1bf Renaming some methods in Transaction::Change
    * 7c1e6d1 Fixing some compatibility and old tests
    * 062afcd Fixing log message when changes fail
    * 9709f66 Changing Transaction to use the new ResourceHarness
    * 4a9e6b8 ResourceHarness now doesn't check params with no 'should'
    * e4ab2ac Fixing #2759 - reports now have complete change info
    * a0cd7c9 Cleaning up the report tests a bit
    * c17729a Removing mention of @changes in Transaction
    * a440f0c Moving Metric management to the reports
    * 3d8d1ac Changing the method profile of EventManager#queue_event
    * ef9061f Refactoring event queueing for performance
    * 521f57c Changing method profile for other event queueing
    * 236b78a Fixing feature validation when passed one item
    * 0393ea3 Fixing broken selinux tests
    * f85efcc Removing now-obsolete "retrieve" method on package type
    * 9854f31 Fixing "require" function to use new class interface
    * 1d2a684 Changing REST report integration test to use new interface
    * 2bb4b6a Fixing fingerprint tests to work with new log validation
    * cc617b0 Fixing Configurer interface to transaction report
    * 46b8a7f Fixing most failing test/ tests.
    * 81b6189 Removing now-obsolete user tests
    7715 examples, 0 failures, 41 pending
        1 fewer in unit/type/schedule.rb (0 total)
    644 tests, 5413 assertions, 39 failures, 22 errors
        1 more in /network/client/resource.rb (1 total)
        1 more in /network/handler/report.rb (1 total)
        4 more in /network/handler/resource.rb (4 total)
        2 more in /other/report.rb (3 total)
        12 more in /other/transactions.rb (12 total)
        1 more in /ral/providers/user.rb (3 total)
        1 more in /ral/type/exec.rb (3 total)
        3 more in /ral/type/file.rb (3 total)
        2 more in /ral/type/file/target.rb (2 total)
        1 more in /ral/type/group.rb (1 total)
        3 more in /ral/type/yumrepo.rb (3 total)
ethanrowe:tickets/master/2239 (TERM signal) succeeded:
    * e41f7f6 Fix 2239 (step one): introduce global settings
represeting applicat...
    * 591555c Fix 2239 (step two): introduce
Puppet::Application.controlled_run m...
    * bcf2113 Fix 2239 (step three): Refactored Puppet::Agent to base
starting/re...
    * a7cbdae Fix 2239 (step four): Refactored Puppet::Daemon's
stop/restart meth...
    * 2c2b700 Fix 2239 (step five): introduce new
Puppet::Transaction#stop_proces...
    * 0312819 Resolving conflicts with testing
    7737 examples, 0 failures, 41 pending
    644 tests, 5422 assertions, 39 failures, 21 errors
        1 fewer in /ral/providers/user.rb (2 total)
martin:tickets/0.25.x/3412 (. is not a tempdir) succeeded:
    * c56adaa Fix for #3412 install.rb should not put "." first in the tmp_dirs
    7737 examples, 0 failures, 41 pending
    644 tests, 5418 assertions, 39 failures, 22 errors
        1 more in /ral/providers/user.rb (3 total)
martin:tickets/0.25.x/3399 (zone type should handle exclusive IP
stacks) succeeded:
    * d6d0ec7 Fix for #3399 zone type should handle exclusive IP stacks
    7751 examples, 0 failures, 41 pending
    644 tests, 5422 assertions, 39 failures, 21 errors
        1 fewer in /ral/providers/user.rb (2 total)
markus:ticket/master/3113 (Wait for smf status change) succeeded:
    * bcd7d65 Fixes #3113 - When importing a manifest puppet needs to chill
    7751 examples, 0 failures, 41 pending
    644 tests, 5418 assertions, 39 failures, 22 errors
        1 more in /ral/providers/user.rb (3 total)
markus:ticket/master/2604 (ZAML) succeeded:
    * cde2df2 Fix for #2604 Pure Ruby yaml generation
    7751 examples, 0 failures, 41 pending
    644 tests, 5411 assertions, 40 failures, 21 errors
        1 more in /ral/providers/cron/crontab.rb (1 total)
        1 fewer in /ral/providers/user.rb (2 total)
markus:ticket/0.25.x/3424  (ZAML patch) succeeded:
    * e257f99 Fix for #3424 and tests to prove it.
    7769 examples, 0 failures, 41 pending
    644 tests, 5407 assertions, 40 failures, 24 errors
        2 more in /network/handler/master.rb (2 total)
        1 more in /ral/providers/user.rb (3 total)
markus:ticket/0.25.x/3366 (bool settings fix) succeeded:
    * 900562a Fix for #3366 - --tags '' treated as boolean 'true'
    7771 examples, 0 failures, 41 pending
    644 tests, 5411 assertions, 40 failures, 23 errors
        1 fewer in /ral/providers/user.rb (2 total)
brice:tickets/0.25.x/3396 (Faster event propagation) succeeded:
    * 9ad1cfd Fix inefficient SimpleGraph#matching_edge
    7772 examples, 4 failures, 41 pending
        4 more in unit/simple_graph.rb (4 total)
    644 tests, 5406 assertions, 44 failures, 24 errors
        4 more in /other/transactions.rb (16 total)
        1 fewer in /ral/providers/cron/crontab.rb (0 total)
        1 more in /ral/providers/user.rb (3 total)
        1 more in /ral/type/exec.rb (4 total)
luke:tickets/master/3015 (Per Environment known resource types) succeeded:
    * dcf85f8 Adding []/[]= support to Parser::Resource
    * 1233c85 Fixing test structure
    * aa2462e Adding support for parsing ruby files
    * f847eb1 Removing old, never-used DSL code
    * 96d222f Storing per-environment LoadedCode instances
    * a9a81d0 Renaming LoadedCode to ResourceTypeCollection
    * c303f8d Adding 'known_resource_types' to Environment
    * 4aa5710 Parser now uses Environment resource type collection
    * 5859d11 Moving Rails initialization to Compiler terminus
    * 390da5e Adding helper module for finding known resource types
    * 15cf40c Always warning if autoloading a file fails
    * 6a12d69 Using the RTC helper to find the known resource types
    * 003e521 Fixing callers to Parser to only pass environment
    * ed990bc All non-transient parser references are gone
    * 633b604 Removing Interpreter class
    * 7c10d7e Renaming Parser::ResourceType to Resource::Type
    * aaabc3b Resolving conflicts with ???
    7796 examples, 30 failures, 41 pending
        1 more in unit/node.rb (1 total)
        15 more in unit/parser/compiler.rb (15 total)
        4 more in unit/parser/scope.rb (4 total)
        2 more in unit/resource/catalog.rb (2 total)
        4 more in unit/resource/type.rb (4 total)
    639 tests, 4667 assertions, 123 failures, 72 errors
        5 more in /language/ast.rb (5 total)
        2 more in /language/ast/casestatement.rb (2 total)
        1 more in /language/ast/resource.rb (1 total)
        1 more in /language/ast/resource_reference.rb (1 total)
        1 more in /language/ast/selector.rb (1 total)
        1 more in /language/ast/variable.rb (1 total)
        16 more in /language/functions.rb (16 total)
        29 more in /language/parser.rb (44 total)
        7 more in /language/resource.rb (7 total)
        12 more in /language/scope.rb (14 total)
        36 more in /language/snippets.rb (40 total)
        16 more in /network/handler/fileserver.rb (16 total)
        1 more in /rails/railsparameter.rb (1 total)
        1 fewer in /ral/providers/user.rb (2 total)
luke:tickets/master/1943 (Combine yaml & file termini) succeeded:
    * 5a2286c Adding filename extension support to formats.
    * 1880c9d Adding client and server data dirs
    * 6e9d2a8 Fixing datadir defaults to match new standards
    * 145a157 Converting File terminus to use formats.
    * d05b657 Removing unused Checksum::File terminus
    * 6547c67 Cleaning up a test.
    7787 examples, 31 failures, 41 pending
        1 more in unit/indirector/yaml.rb (1 total)
    639 tests, 4661 assertions, 123 failures, 73 errors
        1 more in /ral/providers/user.rb (3 total)
brice:tickets/0.25.x/3229 (regex case sensitivity) succeeded:
    * f82f7bf Fix #3229 - use original value in case/selector regex matching
    7787 examples, 33 failures, 41 pending
        2 more in unit/parser/ast/leaf.rb (2 total)
    639 tests, 4665 assertions, 123 failures, 72 errors
        1 fewer in /ral/providers/user.rb (2 total)
jesse:feature/master/3394 (REST (3115,3347,3383,3394)) succeeded:
    * 660e389 Feature #3115 REST-ified status()
    * 46b8eb1 Fix a failing test in #3115
    * c104edf Feature #3347 REST-ified FileBucket
    * 7b07c4f Fix tests on #3347
    * 092065e Feature #3383 RAL over REST
    * ffcff25 Feature #3383 Part 2: Remove RAL XMLRPC
    * 926be61 Feature #3394 REST Runner, preparation
    * 02ab54d Feature #3394 REST runner, execution
    7861 examples, 33 failures, 38 pending
        1 fewer in unit/node.rb (0 total)
        1 more in unit/resource.rb (1 total)
    634 tests, 4561 assertions, 124 failures, 74 errors
        1 more in /network/client/dipper.rb (1 total)
        1 more in /ral/providers/user.rb (3 total)
        1 more in /ral/type/file.rb (4 total)
andrew:feature/0.25.x/zypper (zypper for OpenSuSE) succeeded:
    * 9d2f4fa Fixes #1223 Add Zypper support for SuSE machines
    7869 examples, 35 failures, 38 pending
        1 more in unit/node.rb (1 total)
        2 more in unit/provider/package/zypper.rb (2 total)
        1 fewer in unit/resource.rb (0 total)
    634 tests, 4565 assertions, 124 failures, 73 errors
        1 fewer in /ral/providers/user.rb (2 total)
luke:tickets/testing/2954    (Class parameters) succeeded:
    * 6a0c13e Fixing test structure
    * 6a0b9ed Partially fixing #2954 - Adding class parameters
    * d23a825 Changing the interface of Puppet::Resource
    * 18d1d79 Adding an environment helper
    * cdfe061 Removing obsolete Settings comments and require
    * 5573488 Tuning file load order
    * 405c716 Fixing failing Environment unit tests
    * 7c0da08 Adding parameter validation to Puppet::Resource
    * 2dd4da2 TypeCollection now supports namespace arrays
    * 0ecdacc Allowing Environment.new to take an environment
    * dbf6d53 Removing :paramcheck and :typecheck settings
    * d793dde Adding support for class parameters
    * 5f5e537 Removing Resource::Reference classes
    * 37777c5 Adding tmpfile cleanup to tests
    * ab86997 Fixing most of the broken tests in test/
    * d1a4171 Adding strictness checking to resources
    * 4ec5619 Converging the Resource classes further
    * 3ece8ee Fixing type/title resource resolution
    * 2a519f9 Forcing parent evaluation in resource types
    * c67b1dd Finishing renaming :params to :parameters internally
    * f1a8845 Resolving conflicts with luke:tickets/master/2759
    * bcb02ae Resolving conflicts with jesse:feature/master/3394
    7953 examples, 47 failures, 38 pending
        1 fewer in unit/node.rb (0 total)
        1 more in unit/parser/functions/require.rb (1 total)
        8 more in unit/parser/scope.rb (12 total)
        4 more in unit/resource/type.rb (8 total)
    590 tests, 4788 assertions, 72 failures, 42 errors
        2 fewer in /language/ast.rb (3 total)
        1 fewer in /language/ast/resource.rb (0 total)
        1 fewer in /language/ast/resource_reference.rb (0 total)
        2 fewer in /language/functions.rb (14 total)
        39 fewer in /language/parser.rb (5 total)
        7 fewer in /language/resource.rb (0 total)
        10 fewer in /language/scope.rb (4 total)
        16 fewer in /network/handler/fileserver.rb (0 total)
        1 more in /other/report.rb (4 total)
        8 fewer in /other/transactions.rb (8 total)
        1 fewer in /rails/railsparameter.rb (0 total)
        1 more in /ral/manager/type.rb (1 total)
        1 more in /ral/providers/user.rb (3 total)
        1 more in /ral/type/resources.rb (1 total)
markus:refactor/master/3216 (String interpolation) succeeded:
    * 7ad90cc Moving the string interpolation parsing to the parser/lexer
    7968 examples, 48 failures, 38 pending
        1 more in unit/resource.rb (1 total)
    590 tests, 4774 assertions, 73 failures, 41 errors
        1 more in /language/parser.rb (6 total)
        1 fewer in /ral/providers/user.rb (2 total)
luke:tickets/master/3096     (internal DSL) succeeded:
    * c131390 Adding environment support to parser resources
    * ae61923 Adding simplistic pure ruby interface
    * 0e9ac22 s/DSL::ResourceHelper/DSL::ResourceAPI/g
    * d40ab56 Cleaning up ResourceAPI tests
    * fc0c746 Adding virtual and exported resource support to the DSL
    * 07c112e Resolving conflicts with luke:tickets/testing/2954
    8012 examples, 49 failures, 45 pending
        1 more in unit/parser/resource.rb (1 total)
    590 tests, 4770 assertions, 73 failures, 42 errors
        1 more in /ral/providers/user.rb (3 total)
luke:tickets/master/3398 (Checksum parameter) succeeded:
    * 9a5c95b Refactoring File[source] tests somewhat
    * bf5a845 Adding "checksum?" helper method to Checksums module
    * 884f466 Converted File[checksum] to a parameter not property
    * 19d4968 Fixing change printing for content/ensure
    * 475688d Fixing a typo from a regex
    8028 examples, 55 failures, 45 pending
        1 more in unit/type/file.rb (1 total)
        5 more in unit/type/file/checksum.rb (5 total)
    590 tests, 4774 assertions, 73 failures, 41 errors
        1 fewer in /ral/providers/user.rb (2 total)
ran ruby ../refactor/refactor.rb:
    * c525c12 Code smell: Miscellaneous oddity removal
    * 39daa83 Code smell: Inconsistent indentation and related formatting issues
    * b3704de Code smell: Use {} for % notation delimiters wherever practical
    * d884018 Code smell: English names for special globals rather
than line-noise
    * 34951a0 Code smell: Use string interpolation
    * 56c02c4 Code smell: Line modifiers are preferred to one-line blocks.
    * 0881c2d Code smell: Booleans are first class values.
    * 99d7627 Code smell: Omit needless checks on defined
    * b1bf154 Code smell: Avoid needless decorations
    * fcc66b0 Code smell: Two space indentation
    8025 examples, 54 failures, 45 pending
        1 fewer in unit/resource.rb (0 total)
    590 tests, 4766 assertions, 76 failures, 41 errors
        1 more in /language/parser.rb (7 total)
        1 more in /ral/providers/host/parsed.rb (1 total)
        1 more in /ral/providers/user.rb (3 total)

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to