Today's edition features a reintroduction of some of the futures work,
this time more organized into logically coherent commits and
dynamically based on the head of testing (on top of the code smell
refactorings).
The big stumbling block at this point is still the test failures
introduced by the events branch; despite some focused effort we've not
yet gotten them cleaned up.
-- Markus
Mon Apr 5 23:31:37 PDT 2010
Starting at 164f1ce85bad49c7e197deeb452828c94539e06e
testing (Branching off master) succeeded:
*
7483 examples, 0 failures, 40 pending
662 tests, 5994 assertions, 58 failures, 16 errors
jesse:ticket/0.25.x/3423 (Unit test fixes) succeeded:
* 2b8125c Replace test/unit file write test with spec
* 11379c0 Removing old test for service/debian provider
* 000d37a Removing resources generate tests
* 74f5167 Mock user in SUIDManager tests
* 06deee7 Fix test using wrong Puppet util filesetting group
* 6a148e2 Supressing warnings (not really failures) in test/unit
7485 examples, 0 failures, 40 pending
658 tests, 5983 assertions, 53 failures, 14 errors
2 fewer in /ral/providers/service/debian.rb (0 total)
1 fewer in /ral/providers/user.rb (2 total)
1 fewer in /ral/type/file.rb (0 total)
2 fewer in /ral/type/resources.rb (0 total)
1 fewer in /util/settings.rb (2 total)
jesse:repairs/master/test-unit-tests (More unit test fixes) succeeded:
* 5b2802c Typo in method call in test.
* b19a044 Some tests were leaking state when the test failed
7485 examples, 0 failures, 40 pending
(unit test summary not available)
1 fewer in /language/scope.rb (2 total)
36 fewer in /language/snippets.rb (4 total)
1 fewer in /ral/providers/user.rb (1 total)
reinh:feature/master/single_executable succeeded:
* 7a32777 Renaming applications, mostly removing 'puppet'
* be0ecf8 Initial puppet single executable
* 3c8d012 Fix application name in bin/ralsh
* deff92d Find both bin and sbin usage docs, fail gracefully
* c014c29 Renaming the old puppet executable
* e7bc19a Rename puppet application spec to main
* b4b07f5 Fix failing specs
* 98581ad Fix builtins glob in single executable
7485 examples, 2 failures, 40 pending
2 more in unit/util/monkey_patches.rb (2 total)
658 tests, 6058 assertions, 17 failures, 14 errors
bkearney:ticket/0.25.x/3387 (Backslashes in augeas) succeeded:
* a8245d8 Handle path elements with ticks and spaces
* 7ab29c4 Unit tests for path changes
* b2d1728 fixed a couple of typos
7487 examples, 2 failures, 40 pending
658 tests, 6062 assertions, 17 failures, 13 errors
1 fewer in /ral/providers/user.rb (2 total)
luke:tickets/master/2759 (Events) succeeded:
* 379ac8f Moving log destination code into separate files
* 6a450c5 removing never-used code
* 2cbd9e8 Switching transactions to callback-based events
* 3c86666 Moving Parameter utility classes into separate files
* 32d34e9 Moving Ensure property into separate file
* ad90900 Random code cleanup
* 8280987 Adding "type" instance method to enhance Demeterness
* 4212f1c Cleaning up Event creation
* ee9cff9 Reorganizing Property class to match current style
* f8d7c44 Moving event creation to the resource
* 329527f Changing SimpleGraph.matching_edges to expect one event
* f2ed655 Extracting event management into a separate class
* 9a78bee Adding tests for the 'report' log destination
* 5a8b460 Removing unused code and adding a couple of tests
* 2aa579b Removing a redundant method in Report
* 4be8601 Adding Transaction events to Transaction reports
* 73f57f2 removing extraneous comment
* f925475 Fixing file content logs
* a4b77f6 Failing in app/puppet if facts are not found
* 242209d Correcting comments and making report timestamp internal
* c6dd180 Adding tests for "Logging" module
* d93d80a Using Logging module in main Puppet module
* 2292b76 Refactoring the RAL interface to logging
* 5776fe4 Cleaning up the Log initialization code.
* 977595b Refactoring the Change/Event/Property interface
* e838bcc Solidifying the RAL/Event integration.
* 796d882 Removing last event collection transaction code
* 4bb35a7 Fixing File type indentation
* 6651aa4 Adding first version of Resource::Status class
* 8d5f052 Adding Transaction::ResourceHarness class
* c30494f Renaming some methods in Transaction::Change
* 149d5ef Fixing some compatibility and old tests
* 6051599 Fixing log message when changes fail
* 3f6c948 Changing Transaction to use the new ResourceHarness
* fbd5b0a ResourceHarness now doesn't check params with no 'should'
* 386b3e5 Fixing #2759 - reports now have complete change info
* a18769d Cleaning up the report tests a bit
* a9fc134 Removing mention of @changes in Transaction
* 9919b14 Moving Metric management to the reports
* 68ce086 Changing the method profile of EventManager#queue_event
* ec7ea27 Refactoring event queueing for performance
* 5aa26d0 Changing method profile for other event queueing
* 2777e1f Fixing feature validation when passed one item
* 67a75db Fixing broken selinux tests
* 266bc08 Removing now-obsolete "retrieve" method on package type
* fdefb64 Fixing "require" function to use new class interface
* f4ef039 Changing REST report integration test to use new interface
* eb0a4b5 Fixing fingerprint tests to work with new log validation
* 9d9b20f Fixing Configurer interface to transaction report
* 7627441 Fixing most failing test/ tests.
* 0f768ed Removing now-obsolete user tests
* 8465cd0 Resolving conflicts with reinh:feature/master/single_executable
7715 examples, 2 failures, 41 pending
644 tests, 5418 assertions, 39 failures, 22 errors
1 more in /network/client/resource.rb (1 total)
1 more in /network/handler/report.rb (1 total)
4 more in /network/handler/resource.rb (4 total)
2 more in /other/report.rb (3 total)
12 more in /other/transactions.rb (12 total)
1 more in /ral/providers/user.rb (3 total)
1 more in /ral/type/exec.rb (3 total)
3 more in /ral/type/file.rb (3 total)
2 more in /ral/type/file/target.rb (2 total)
1 more in /ral/type/group.rb (1 total)
3 more in /ral/type/yumrepo.rb (3 total)
ethanrowe:tickets/master/2239 (TERM signal) succeeded:
* 425a782 Fix 2239 (step one): introduce global settings
represeting applicat...
* f0644ef Fix 2239 (step two): introduce
Puppet::Application.controlled_run m...
* 95cf93e Fix 2239 (step three): Refactored Puppet::Agent to base
starting/re...
* 3075699 Fix 2239 (step four): Refactored Puppet::Daemon's
stop/restart meth...
* fbea11b Fix 2239 (step five): introduce new
Puppet::Transaction#stop_proces...
* b5196bb Resolving conflicts with testing
7737 examples, 10 failures, 41 pending
8 more in unit/util/autoload.rb (8 total)
644 tests, 5422 assertions, 39 failures, 21 errors
1 fewer in /ral/providers/user.rb (2 total)
martin:tickets/0.25.x/3412 (. is not a tempdir) succeeded:
* 283cfbb Fix for #3412 install.rb should not put "." first in the tmp_dirs
7737 examples, 10 failures, 41 pending
644 tests, 5418 assertions, 39 failures, 22 errors
1 more in /ral/providers/user.rb (3 total)
martin:tickets/0.25.x/3399 (zone type should handle exclusive IP
stacks) succeeded:
* 95dcbd6 Fix for #3399 zone type should handle exclusive IP stacks
* 21b935f fix for #3399 zone type should handle exclusive IP
stacks (correcte...
* 8928555 fix #3399 - zone type should handle exclusive IP stacks
(added clon...
7753 examples, 12 failures, 41 pending
2 more in unit/provider/zone/solaris.rb (2 total)
644 tests, 5422 assertions, 39 failures, 21 errors
1 fewer in /ral/providers/user.rb (2 total)
markus:ticket/master/3113 (Wait for smf status change) succeeded:
* f24f6dc Fixes #3113 - When importing a manifest puppet needs to chill
7753 examples, 12 failures, 41 pending
644 tests, 5418 assertions, 39 failures, 22 errors
1 more in /ral/providers/user.rb (3 total)
markus:ticket/master/2604 (ZAML) succeeded:
* 5b1dab1 Fix for #2604 Pure Ruby yaml generation
7753 examples, 12 failures, 41 pending
644 tests, 5415 assertions, 39 failures, 21 errors
1 fewer in /ral/providers/user.rb (2 total)
markus:ticket/0.25.x/3424 (ZAML patch) succeeded:
* f454127 Fix for #3424 and tests to prove it.
7771 examples, 4 failures, 41 pending
8 fewer in unit/util/autoload.rb (0 total)
644 tests, 5409 assertions, 39 failures, 24 errors
2 more in /network/handler/master.rb (2 total)
1 more in /ral/providers/user.rb (3 total)
markus:ticket/0.25.x/3366 (bool settings fix) succeeded:
* 4628605 Fix for #3366 - --tags '' treated as boolean 'true'
7773 examples, 4 failures, 41 pending
644 tests, 5413 assertions, 39 failures, 23 errors
1 fewer in /ral/providers/user.rb (2 total)
luke:tickets/master/3015 (Per Environment known resource types) succeeded:
* 5f94189 Adding []/[]= support to Parser::Resource
* 86d77ca Fixing test structure
* f1dc236 Adding support for parsing ruby files
* 947aa78 Removing old, never-used DSL code
* b26f880 Storing per-environment LoadedCode instances
* cb780ec Renaming LoadedCode to ResourceTypeCollection
* 77004e9 Adding 'known_resource_types' to Environment
* 43ee1cf Parser now uses Environment resource type collection
* 80fe0a8 Moving Rails initialization to Compiler terminus
* 1a310fd Adding helper module for finding known resource types
* 69564fa Always warning if autoloading a file fails
* 5f15fb1 Using the RTC helper to find the known resource types
* f20d5c2 Fixing callers to Parser to only pass environment
* 06c6659 All non-transient parser references are gone
* 0f90dcf Removing Interpreter class
* f57f847 Renaming Parser::ResourceType to Resource::Type
* bb1e8f5 Resolving conflicts with ???
7797 examples, 6 failures, 41 pending
1 more in unit/node.rb (1 total)
1 more in unit/resource/type.rb (1 total)
639 tests, 4743 assertions, 81 failures, 73 errors
5 more in /language/ast.rb (5 total)
2 more in /language/ast/casestatement.rb (2 total)
1 more in /language/ast/resource.rb (1 total)
1 more in /language/ast/resource_reference.rb (1 total)
1 more in /language/ast/selector.rb (1 total)
1 more in /language/ast/variable.rb (1 total)
16 more in /language/functions.rb (16 total)
29 more in /language/parser.rb (44 total)
7 more in /language/resource.rb (7 total)
12 more in /language/scope.rb (14 total)
16 more in /network/handler/fileserver.rb (16 total)
1 more in /rails/railsparameter.rb (1 total)
luke:tickets/master/1943 (Combine yaml & file termini) succeeded:
* 88fabf0 Adding filename extension support to formats.
* 83dc723 Adding client and server data dirs
* e2c048e Fixing datadir defaults to match new standards
* 065017f Converting File terminus to use formats.
* 16372bf Removing unused Checksum::File terminus
* a65e72b Cleaning up a test.
7788 examples, 7 failures, 41 pending
1 more in unit/indirector/yaml.rb (1 total)
639 tests, 4736 assertions, 81 failures, 74 errors
1 more in /ral/providers/user.rb (3 total)
brice:tickets/0.25.x/3229 (regex case sensitivity) succeeded:
* 3b20e9d Fix #3229 - use original value in case/selector regex matching
7788 examples, 9 failures, 41 pending
2 more in unit/parser/ast/leaf.rb (2 total)
639 tests, 4740 assertions, 81 failures, 73 errors
1 fewer in /ral/providers/user.rb (2 total)
jesse:feature/master/3394 (REST (3115,3347,3383,3394)) succeeded:
* 2f82cc1 Feature #3115 REST-ified status()
* b7ff1ee Fix a failing test in #3115
* 5b50fb8 Feature #3347 REST-ified FileBucket
* bf8e08b Fix tests on #3347
* e618295 Feature #3383 RAL over REST
* 9cd9a8d Feature #3383 Part 2: Remove RAL XMLRPC
* 798e386 Feature #3394 REST Runner, preparation
* e88ff87 Feature #3394 REST runner, execution
* c84c9d9 REST: hide Request object
* 2c02a91 REST FileBucket: REST barfs on relative paths
* fedd206 REST: Fix a state leak causing test failures
* 8d82033 Indirector/FileBucketFile warnings
7861 examples, 13 failures, 38 pending
4 more in unit/application/puppetrun.rb (4 total)
634 tests, 4632 assertions, 82 failures, 75 errors
1 more in /network/client/dipper.rb (1 total)
1 more in /ral/providers/user.rb (3 total)
1 more in /ral/type/file.rb (4 total)
andrew:feature/0.25.x/zypper (zypper for OpenSuSE) succeeded:
* efb8438 Fixes #1223 Add Zypper support for SuSE machines
7869 examples, 15 failures, 38 pending
2 more in unit/provider/package/zypper.rb (2 total)
634 tests, 4636 assertions, 82 failures, 74 errors
1 fewer in /ral/providers/user.rb (2 total)
luke:tickets/testing/2954 (Class parameters) succeeded:
* 052ef72 Fixing test structure
* a84a97f Partially fixing #2954 - Adding class parameters
* 720dc89 Changing the interface of Puppet::Resource
* 96becc2 Adding an environment helper
* fb48fa6 Removing obsolete Settings comments and require
* b5a728f Tuning file load order
* b69e5ab Fixing failing Environment unit tests
* 639e577 Adding parameter validation to Puppet::Resource
* 0516dc5 TypeCollection now supports namespace arrays
* b102d8d Allowing Environment.new to take an environment
* 73e3571 Removing :paramcheck and :typecheck settings
* da1e5a4 Adding support for class parameters
* 812a350 Removing Resource::Reference classes
* f061cb9 Adding tmpfile cleanup to tests
* 778dff8 Fixing most of the broken tests in test/
* 54df53d Adding strictness checking to resources
* bee00f7 Converging the Resource classes further
* 5a0a6f8 Fixing type/title resource resolution
* 1d26846 Forcing parent evaluation in resource types
* f58ed25 Finishing renaming :params to :parameters internally
* 83ed1fc Resolving conflicts with ???
* 69c173d Resolving conflicts with luke:tickets/master/2759
* 0badcbe Resolving conflicts with jesse:feature/master/3394
7953 examples, 26 failures, 38 pending
1 fewer in unit/node.rb (0 total)
1 more in unit/parser/functions/require.rb (1 total)
8 more in unit/parser/scope.rb (8 total)
3 more in unit/resource/type.rb (4 total)
590 tests, 5007 assertions, 29 failures, 18 errors
5 fewer in /language/ast.rb (0 total)
1 fewer in /language/ast/casestatement.rb (1 total)
1 fewer in /language/ast/resource.rb (0 total)
1 fewer in /language/ast/resource_reference.rb (0 total)
1 fewer in /language/ast/variable.rb (0 total)
16 fewer in /language/functions.rb (0 total)
43 fewer in /language/parser.rb (1 total)
7 fewer in /language/resource.rb (0 total)
14 fewer in /language/scope.rb (0 total)
2 fewer in /language/snippets.rb (2 total)
16 fewer in /network/handler/fileserver.rb (0 total)
1 more in /other/report.rb (4 total)
5 fewer in /other/transactions.rb (7 total)
1 fewer in /rails/railsparameter.rb (0 total)
1 more in /ral/manager/type.rb (1 total)
1 more in /ral/providers/user.rb (3 total)
1 more in /ral/type/resources.rb (1 total)
markus:refactor/master/3216 (String interpolation) succeeded:
* e623c5d Moving the string interpolation parsing to the parser/lexer
* 955fbed Resolving conflicts with ???
7968 examples, 26 failures, 38 pending
590 tests, 4989 assertions, 34 failures, 17 errors
1 more in /language/parser.rb (2 total)
4 more in /language/snippets.rb (6 total)
1 fewer in /ral/providers/user.rb (2 total)
luke:tickets/master/3096 (internal DSL) succeeded:
* 37bec7e Adding environment support to parser resources
* 805c27a Adding simplistic pure ruby interface
* 1326e95 s/DSL::ResourceHelper/DSL::ResourceAPI/g
* db67080 Cleaning up ResourceAPI tests
* d7dce32 Adding virtual and exported resource support to the DSL
* 2337d57 Resolving conflicts with luke:tickets/testing/2954
8012 examples, 28 failures, 45 pending
1 more in unit/parser/resource.rb (1 total)
1 more in unit/resource/type.rb (5 total)
590 tests, 4987 assertions, 34 failures, 18 errors
1 more in /ral/providers/user.rb (3 total)
luke:tickets/master/3398 (Checksum parameter) succeeded:
* 1116172 Refactoring File[source] tests somewhat
* 994906e Adding "checksum?" helper method to Checksums module
* daa3a56 Converted File[checksum] to a parameter not property
* 3e06058 Fixing change printing for content/ensure
* bc64460 Fixing a typo from a regex
* c3e9bd7 Resolving conflicts with ???
8023 examples, 29 failures, 45 pending
1 more in unit/type/file.rb (1 total)
590 tests, 4991 assertions, 34 failures, 17 errors
1 fewer in /ral/providers/user.rb (2 total)
ran ruby ../refactor/refactor.rb:
* 2ab956a Code smell: Miscellaneous oddity removal
* 82a2c98 Code smell: Inconsistent indentation and related formatting issues
* da25d2d Code smell: Use {} for % notation delimiters wherever practical
* 615bca9 Code smell: English names for special globals rather
than line-noise
* bf32d3d Code smell: Use string interpolation
* 135a26b Code smell: Line modifiers are preferred to one-line blocks.
* c4c912b Code smell: Booleans are first class values.
* 74853fe Code smell: Avoid explicit returns
* f2a4734 Code smell: Omit needless checks on defined
* 32f7ab0 Code smell: Use ||= for conditional initialization
* d4a77e0 Code smell: Use &&= for dependent initialization
* a2732f5 Code smell: Don't restate results directly after assignment
* 7554ad0 Code smell: Avoid needless decorations
* 76e98ac Code smell: Two space indentation
8020 examples, 27 failures, 45 pending
2 fewer in unit/util/monkey_patches.rb (0 total)
590 tests, 4976 assertions, 37 failures, 18 errors
1 more in /language/functions.rb (1 total)
1 more in /language/parser.rb (3 total)
1 more in /ral/providers/host/parsed.rb (1 total)
1 more in /ral/providers/user.rb (3 total)
ran ruby ../refactor/futures_setup.rb:
* 654a0d9 Fix lingering scope.compiler.class_scope uses
* 4531c43 Rename AST nodes as Expression nodes
* da20f8d Remove 'settor' flag on Expression nodes
* efd4bb3 Expressions denote values, computation is just a means to this end
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
