-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 21/04/10 12:57 AM, Markus Roberts wrote: > This is risky code, in that it does no checking to see if one step > worked before plunging on to the next. It might make sense to use > $CHILD_STATUS liberally or to use something like the Git module (see > refactoring_tools.rb in my tools_for_refactoring_puppet branch). Also, > "git add *" could easily sweep up things we don't want unless the output > dir is brand new & newly populated. And finally the "DISABLED FOR NOW" > comment looks to be out of date.
See my other email but the git add * is okay because a) we're in the generated directory and b) the directory is newly and just then populated. But will look at that code and Michael is correct we could use tags to do something more elegant. Regards James - -- Author of: * Pro Linux System Administration (http://tinyurl.com/linuxadmin) * Pulling Strings with Puppet (http://tinyurl.com/pupbook) * Pro Nagios 2.0 (http://tinyurl.com/pronagios) * Hardening Linux (http://tinyurl.com/hardeninglinux) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEVAwUBS83GCiFa/lDkFHAyAQJsKQgAn/NcXRf5X2NyHo6JkKevEFmafQRfIR0g SjjJ+0VYvbVDo/rM1nqfp7do/G665kc7X7PKcEBYccDTlgis+wxdfnY+StSa0GEg bHMgZS/+zxRHRGEQ/gRf/KIZYMSXQDwWtc7DcSA3qF7SuDPiPVWj8mPzTvZbtfV9 PFVjbcpOmVz/qkGfcfxy71hWZ3daAX/Qld/pVKMezGwgD+X52JJCv3uQW6VDD4xn wWzLhGV3GznQzuzzVGf7bY7ot/W7eU5HVtIyNlyo2BBY28+win/TxQXOh0kh9IJ/ HrUtkjFIpTS23pHJOHhhOYX5IkQfgIrNeBcngngA1FQeajoP+DLh7A== =kv14 -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
