IMO they should at least be in the Testing branch.

On Apr 22, 2010, at 1:25 PM, Trevor Vaughan wrote:

Yes, I uploaded the tests and Luke indicated that it was ready to go
into testing.

They aren't *great* and I can work on those some more, but I'm hoping
that it will be adequate for now.

Thank you,

Trevor

On Thu, Apr 22, 2010 at 2:46 PM, Steven Jenkins
<[email protected]> wrote:
On Thu, Apr 22, 2010 at 2:30 PM, Markus Roberts <[email protected] > wrote:
Trevor --

We'd gotten wedged with merging some of the major refactorings that were done in the November-December time frame, and weren't able to coherently add new changes to the testing branch. We're past that now and I hope to be doing a new testing branch early next week. I've added #2927 to the pull list, and (baring unexpected problems) it should get in. If you'd like to do something more on it, you could create a git branch off the current master with the patch applied and add a url to it to the ticket, but if not
let me know and I'll do it.


Did the tests get written? Last I looked, there was not yet a patch with tests.

Steven

--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected] . For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en .





--
Trevor Vaughan
Vice President, Onyx Point, Inc
(410) 541-6699
[email protected]

-- This account not approved for unencrypted proprietary information --

--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected] . For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en .



--
At my lemonade stand I used to give the first glass away free and charge
five dollars for the second glass. The refill contained the antidote.
    -- Emo Phillips
---------------------------------------------------------------------
Luke Kanies  -|-   http://puppetlabs.com   -|-   +1(615)594-8199

--
You received this message because you are subscribed to the Google Groups "Puppet 
Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to