James,

I might be completely wrong, but ... I believe that the following may
throw an exception as "empty" is not a known method for Fixnum since
during the parsing stage in settings.rb we munge arguments and cast
them according to what type they look like (upon matching with regular
expression), and it will be Integer in this case:

+            args[:port]     = Puppet[:dbport] unless
Puppet[:dbport].empty?

This probably should say:

+            args[:port]     = Puppet[:dbport] unless
Puppet[:dbport].zero?

Said that, I reckon this has to be changed as well:

+        args[:port]     = pm_conf[:dbport] unless
pm_conf[:dbport].to_s.empty?

To:

+        args[:port]     = pm_conf[:dbport].to_i unless
pm_conf[:dbport].to_i.zero?

[...]

Perhaps rake tests also need some love in that regards. Anyway, does
this makes any sense? :-)

KW

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to