+1. On Tue, Jun 15, 2010 at 4:04 PM, Matt Robinson <[email protected]> wrote:
> When Markus reverted changes made by 2890 he reintroduced a > method certificate_matches_key? that then caused failures in > network/xmlrpc/client.rb. I just stubbed that method to return true > since the failing tests weren't trying to test that methods behavior. > > Reviewed-by: Markus Roberts > > Signed-off-by: Matt Robinson <[email protected]> > --- > spec/unit/network/xmlrpc/client.rb | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/spec/unit/network/xmlrpc/client.rb > b/spec/unit/network/xmlrpc/client.rb > index 328688b..1b97583 100755 > --- a/spec/unit/network/xmlrpc/client.rb > +++ b/spec/unit/network/xmlrpc/client.rb > @@ -5,9 +5,9 @@ Dir.chdir(File.dirname(__FILE__)) { (s = lambda { |f| > File.exist?(f) ? require(f > describe Puppet::Network::XMLRPCClient do > describe "when performing the rpc call" do > before do > + > Puppet::SSL::Host.any_instance.stubs(:certificate_matches_key?).returns > true > @client = Puppet::Network::Client.report.xmlrpc_client.new > @client.stubs(:call).returns "foo" > - > end > > it "should call the specified namespace and method, with the > specified arguments" do > -- > 1.7.0.4 > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<puppet-dev%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > -- ----------------------------------------------------------- The power of accurate observation is commonly called cynicism by those who have not got it. ~George Bernard Shaw ------------------------------------------------------------ -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
