On Fri, Jul 16, 2010 at 1:04 AM, Brice Figureau <[email protected]> wrote: > +1. > > There's one thing I just noticed re-reading the code is that imported > modules don't seem to get their module_name associated. > It's not a big deal, but might be addressed by your patch, though.
No, unfortunately to do that would require having import go through the find_or_load interface of type_collector or refactoring the load_until to not take a block and unraveling that mess. I'd started along that path and then decided to go with something more cautious. Do you have an feel for the user-visible consequences of explicitly imported not getting their module_name assigned? Is this something we should try to fix while we're here, or better left for the post 2.6.0 cleanup pass unless/until there's a clear need before that. -- Markus ----------------------------------------------------------- The power of accurate observation is commonly called cynicism by those who have not got it. ~George Bernard Shaw ------------------------------------------------------------ -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
