-1, or really just zero. I had worked this up to explore the test changes on Nick & Matt's branch to see why they didn't break; Matt's response to my question on that thread explained it, but then I accidentally mailed this test version. It works, but the test fixes are missing.
On Sat, Jul 17, 2010 at 6:09 PM, Markus Roberts <[email protected]> wrote: > From: Matt Robinson <[email protected]> > > Node parameters were made a reader instead of an accessor in > > commit b82b4ef04282ca0006931562f60459a1591b6268 > Author: Luke Kanies <[email protected]> > Date: Wed Jan 6 17:42:42 2010 -0800 > > All non-transient parser references are gone > > but external nodes needs to be able to assign to parameters. The fix is > just to change that back to an accessor. There may have been concern > over nodes replacing the hash object instead of the values could have > bad consequences, but that's not a concern since the node object being > created in this case is new also. > > Paired with: Nick Lewis > Revised by: Markus Roberts > > This is just the functional change (reverting the reader to an accessor) > without > the styistic changes to the tests. > > Signed-off-by: Markus Roberts <[email protected]> > --- > lib/puppet/node.rb | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/puppet/node.rb b/lib/puppet/node.rb > index 1fc6154..2453cd1 100644 > --- a/lib/puppet/node.rb > +++ b/lib/puppet/node.rb > @@ -16,8 +16,8 @@ class Puppet::Node > indirects :node, :terminus_setting => :node_terminus, :doc => "Where to > find node information. > A node is composed of its name, its facts, and its environment." > > - attr_accessor :name, :classes, :source, :ipaddress > - attr_reader :time, :parameters > + attr_accessor :name, :classes, :source, :ipaddress, :parameters > + attr_reader :time > > def environment > return super if @environment > -- > 1.6.4 > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > -- ----------------------------------------------------------- The power of accurate observation is commonly called cynicism by those who have not got it. ~George Bernard Shaw ------------------------------------------------------------ -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
