On 3 August 2010 23:03, Rein Henrichs <r...@puppetlabs.com> wrote:
> From: Rein Henrichs <re...@reinh.com>
>
> Rewrite of uptime facts and supporting utility methods. Works on unix,
> BSD, windows. No longer makes redundant system calls.
>
> Uses Facter::Util::Uptime utility methods:
>
Thanks for this, not had time to look in anger but a quick scan shows:
> + def self.uptime_proc_uptime
> + if File.exists? uptime_file
> + r = File.read uptime_file
> + r.split(" ").first.to_i
> + end
> + end
<snip>
> end
>
> - def self.get_uptime
> - r = IO.popen("/bin/cat /proc/uptime")
You've moved to read from cat, that'll likely break on RHEL 4 see
http://projects.reductivelabs.com/issues/2355 for example
Paul
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-...@googlegroups.com.
To unsubscribe from this group, send email to
puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
