Dan, We already talked about this off list, but I thought I'd mention that the portion of the patch that actually allows the implementation to do yum downgrade wasn't included in the mailed patches. It's all there in your github branch though.
http://github.com/bodepd/puppet/tree/ticket/2.6.1rc3/2866 Jesse has stated that he wants tests to pass for every commit, so he may ask you to squash that last commit that adds the downgrade implementation when it comes time to merge this. Also your patch for 2866 is based on your patch for 4711, but each ticket has a different branch on it. That may be confusing to whoever merges this, so I thought I'd point that out just in case. I made a comment on how you can better write the downgrade test in a separate email, so once that change is made I'm +1. Wait, one more thing. I noticed in the yum implementation there's an assignment to a variable that's never used. You didn't introduce this, but it might as well get changed in your commit series. diff --git a/lib/puppet/provider/package/yum.rb b/lib/puppet/provider/package/yum.rb index 6ed966f..f2f21e3 100755 --- a/lib/puppet/provider/package/yum.rb +++ b/lib/puppet/provider/package/yum.rb @@ -70,7 +70,7 @@ Puppet::Type.type(:package).provide :yum, :parent => :rpm, :source => :rpm do end end - output = yum "-d", "0", "-e", "0", "-y", operation, wanted + yum "-d", "0", "-e", "0", "-y", operation, wanted is = self.query raise Puppet::Error, "Could not find package #{self.name}" unless is Matt On Tue, Sep 7, 2010 at 3:08 PM, Dan Bode <[email protected]> wrote: > these patches should be applied togther. they add support for yum downgrade. > > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
