Fix is_virtual fact to return strings rather than bools.
Signed-off-by: Paul Nasrat <[email protected]>
---
lib/facter/virtual.rb | 4 ++--
spec/unit/virtual.rb | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/facter/virtual.rb b/lib/facter/virtual.rb
index c14a715..af530e5 100644
--- a/lib/facter/virtual.rb
+++ b/lib/facter/virtual.rb
@@ -81,9 +81,9 @@ Facter.add("is_virtual") do
setcode do
case Facter.value(:virtual)
when "xenu", "openvzve", "vmware", "kvm", "vserver", "jail"
- true
+ "true"
else
- false
+ "false"
end
end
end
diff --git a/spec/unit/virtual.rb b/spec/unit/virtual.rb
index 8ee843b..80cd0d9 100644
--- a/spec/unit/virtual.rb
+++ b/spec/unit/virtual.rb
@@ -35,37 +35,37 @@ describe "is_virtual fact" do
it "should be virtual when running on xen" do
Facter.fact(:kernel).stubs(:value).returns("Linux")
Facter.fact(:virtual).stubs(:value).returns("xenu")
- Facter.fact(:is_virtual).value.should == true
+ Facter.fact(:is_virtual).value.should == "true"
end
it "should be false when running on xen0" do
Facter.fact(:kernel).stubs(:value).returns("Linux")
Facter.fact(:virtual).stubs(:value).returns("xen0")
- Facter.fact(:is_virtual).value.should == false
+ Facter.fact(:is_virtual).value.should == "false"
end
it "should be true when running on vmware" do
Facter.fact(:kernel).stubs(:value).returns("Linux")
Facter.fact(:virtual).stubs(:value).returns("vmware")
- Facter.fact(:is_virtual).value.should == true
+ Facter.fact(:is_virtual).value.should == "true"
end
it "should be true when running on openvz" do
Facter.fact(:kernel).stubs(:value).returns("Linux")
Facter.fact(:virtual).stubs(:value).returns("openvzve")
- Facter.fact(:is_virtual).value.should == true
+ Facter.fact(:is_virtual).value.should == "true"
end
it "should be true when running on kvm" do
Facter.fact(:kernel).stubs(:value).returns("Linux")
Facter.fact(:virtual).stubs(:value).returns("kvm")
- Facter.fact(:is_virtual).value.should == true
+ Facter.fact(:is_virtual).value.should == "true"
end
it "should be true when running in jail" do
Facter.fact(:kernel).stubs(:value).returns("FreeBSD")
Facter.fact(:virtual).stubs(:value).returns("jail")
- Facter.fact(:is_virtual).value.should == true
+ Facter.fact(:is_virtual).value.should == "true"
end
end
--
1.7.0.3
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
