Angelos --

I poked at it a bit but didn't have any blinding insights.  A few
observations:

 > # Verify that the passed value is valid.

>   # If the developer uses a 'validate' hook, this method will get
> overridden.
>
  def unsafe_validate(value)
>     self.class.value_collection.validate(value)
> +    validate_features_per_value(value)
>   end
>

As the comment notes, putting the call to validate_features_per_value here
is at risk because it could be trounced by the validate hook.  It may make
more sense to put it in validate, right after the call to unsafe_validate
(but still inside the begin block) for this reason.  That said, I don't
think that's causing the problem you are seeing.

@@ -299,16 +285,6 @@ class Puppet::Property < Puppet::Parameter
>   # If the developer uses a 'validate' hook, this method will get
> overridden.
>   def unsafe_validate(value)
>     super
> -    validate_features_per_value(value)
> -  end
>

You can just eliminate the whole method if all it does is call super.

Overall it looks pretty good, but I suspect I'm missing something.

What are you using for a test case?  Can you update the ticket with a bit
more information about how you're trying it, and maybe that will suggest
something.

-- Markus
-----------------------------------------------------------
The power of accurate observation is
commonly called cynicism by those
who have not got it.  ~George Bernard Shaw
------------------------------------------------------------

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to