> So what do you think is the best way to improve this patch? > I was afraid you'd ask that. I think I'd:
1) check how many of the calls to lookupvar really are divorced from an AST::Node & why 2) refactor the stray calls to lookupvar where needed 3) refactor lookupvar to accept a "context" 4) modify lookupvar to detect dynamic scope resolution as it happens, rather than doing two passes (see above) 5) make a singleton that represented the warnings issued so far so that we only warn once per (static) instance, not once per compile (which could well result in thousands of warnings per error) 6) deal with whatever unexpected complications came up and gnash my teeth, etc. I'll start on that and report back with contrition if it turns out that I'm just grossly oversimplifying the issues implicit in 6). -- M ----------------------------------------------------------- The power of accurate observation is commonly called cynicism by those who have not got it. ~George Bernard Shaw ------------------------------------------------------------ -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
