Hi Luke! On Nov 16, 2010, at 8:41 AM, Luke Kanies wrote:
>> There's no official puppet policy on this, as far as I know, but I'm >> inclined to say that we should only accept cleanup/refactoring patches if >> they are part of a series of changes that also adds or fixes functionality. >> Does anyone else have an opinion on the matter? > > I think the exact opposite should be true - accept cleanup and refactoring > patches wherever and whenever we can. > Heck, I think we should give extra credit for refactoring patches that change > no behaviour at all. Awesome! I really like your suggestion, because in my opinion it is one part of being agile. Your e-mail makes me happy. :-) > As to whether all of his changes meet our standards, his points about our > standards not being published is a good point, and I think it makes sense to > use his patch as a forcing function to publish what bits are not yet decided. I hope you at puppetlabs discuss it and make a decision that is open, agile and does not annoy the community nor developers at puppetlabs. All the best, Sandor Szücs -- -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
