On 18 November 2010 14:07, David Schmitt <da...@dasz.at> wrote:
> On 11/18/2010 11:13 AM, donavanm wrote:
>>
>> @@ -80,11 +103,11 @@ Facter.add("virtual") do
>> end
>>
>> Facter.add("is_virtual") do
>> - confine :kernel => %w{Linux FreeBSD OpenBSD SunOS HP-UX}
>> + confine :kernel => %w{Linux FreeBSD OpenBSD SunOS HP-UX Darwin}
>>
>> setcode do
>> case Facter.value(:virtual)
>> - when "xenu", "openvzve", "vmware", "kvm", "vserver", "jail",
>> "zone", "hpvm"
>> + when "xenu", "openvzve", "vmware", "kvm", "vserver", "jail",
>> "zone", "hpvm", "parallels"
>> "true"
>> else
>> "false"
>
> I'm not familiar with the code, but wouldn't this require less changes if it
> would just check for virtual != "physical" ?
Yeah at this stage that makes a lot of sense, it's just grown organically.
Paul
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-...@googlegroups.com.
To unsubscribe from this group, send email to
puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
