I agree, this isn't really the best way to do it, given stages. I think some kind of metatag like 'all' (which the tagmail report processor uses) or supporting '*' or something similar is the better move.
On Nov 25, 2010, at 8:12 AM, Nigel Kersten wrote: > I'm not entirely convinced this is the best way to achieve this, so > consider this a discussion starting point. > > --tags main should probably just be the main Stage, do we want to make > people explicitly list their stages, or do we want an "--alltags" > option of some kind? > > On Nov 25, 8:04 am, Nigel Kersten <[email protected]> wrote: >> From: Nigel Kersten <[email protected]> >> >> Sent on behalf of Tim Nicholas. >> Make --tags main apply all resources. >> >> Signed-off-by: Nigel Kersten <[email protected]> >> --- >> lib/puppet/util/tagging.rb | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/lib/puppet/util/tagging.rb b/lib/puppet/util/tagging.rb >> index 6323ee0..a4556d6 100644 >> --- a/lib/puppet/util/tagging.rb >> +++ b/lib/puppet/util/tagging.rb >> @@ -21,6 +21,8 @@ module Puppet::Util::Tagging >> >> # Are we tagged with the provided tag? >> def tagged?(*tags) >> + # If one of the tags passed is a 'main' then it will always match >> + if tags.include?("main") then return true end >> not ( self.tags & tags.flatten.collect { |t| t.to_s } ).empty? >> end >> >> -- >> 1.7.2.3 > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > -- I can win an argument on any topic, against any opponent. People know this, and steer clear of me at parties. Often, as a sign of their great respect, they don't even invite me. -- Dave Barry --------------------------------------------------------------------- Luke Kanies -|- http://puppetlabs.com -|- +1(615)594-8199 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
