On Nov 23, 2010, at 10:35 AM, Stefan Schulte wrote:

> On Tue, Nov 23, 2010 at 12:36:07AM -0600, Luke Kanies wrote:
>> If you invert it, it works better:
>> 
>> port { '22/udp': label => 'telnet' }
>> 
> 
> Havent thought of that an it looks pretty good for me. The duplication
> doesnt really bothers me, because I can easily write a define for that.
> 
> But what I dont like about that approach is, that while it is good for
> adding entries its just near to useless when you're trying to detect
> errors. Because I think you rareley want to change the
> label of a port but maybe you want to check, if the specified port is
> actually right. (At least I want to do that). So in the example abvoe:
> If I already have
> 
>  telnet 20/udp # someone copied&pasted but didnt changed port
> 
> in my file, puppet will happily adding another telnet entry.

Hmm, you're right - in that case, telnet would look up to multiple values, 
which isn't acceptable.  It's really all three pieces that are primary - the 
name, number, and protocol.

Yuck.

-- 
If computers get too powerful, we can organize them into a committee --
that will do them in.    -- Bradley's Bromide
---------------------------------------------------------------------
Luke Kanies  -|-   http://puppetlabs.com   -|-   +1(615)594-8199




-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to