On Dec 1, 2010, at 6:39 AM, Peter Meier wrote: > Hi > > so this is my attempt to fix #5392 (with a little refactor that caught > my attention). > > It does not contain any tests, because while writing possible tests it > became less and less clear whether this is actually the right fix at the > right place. For the record: it fixes my problem in my infrastructur(TM) > without any side-effects for over a week now. > > The problem, as far as I understand it, is that > scope.find_resource_type(@type) returns nil for a type of a collection > if _no_ resources of that type are exported so far. So my feeling > tells me that rather this is the real problem than the ducktape I'm > applying with this patch. Shouldn't the type anway be found? If yes, > where are things really going wrong? This is a bit beyond my > current understanding of the puppet internals.
This seems like a bigger refactor is a good idea - that is, it seems stupid that find_resource_type should return nil if resources aren't found, but should do so only if the resource type isn't found. The current state is certainly confusing. -- I object to doing things that computers can do. --Olin Shivers --------------------------------------------------------------------- Luke Kanies -|- http://puppetlabs.com -|- +1(615)594-8199 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
