On 02/12/10 23:27, Paul Berry wrote: > On Tue, Nov 30, 2010 at 4:27 AM, Dominic Cleal <dcl...@redhat.com > <mailto:dcl...@redhat.com>> wrote: > > Add total memory from prtconf output, free from vmstat plus swap > free and > total from swap -l listing. > > Signed-off-by: Dominic Cleal <dcl...@redhat.com > <mailto:dcl...@redhat.com>> > > It looks like there are two independent changes here. In addition to > adding facts for SunOS, this change refactors the OpenBSD MemoryFree > fact, moving it to util/memory.rb and rewriting it to use a regular > expression. Was the OpenBSD change intentional? Because if so it > should probably be in a separate commit, and also it probably could be > better written using split() rather than a regular expression to pick > out the fifth column.
Thanks for the feedback Paul. The change was intentional as the Solaris MemoryFree code would have been identical. I'll resubmit this as two separate commits and use split(). Cheers, -- Dominic Cleal Red Hat Consulting m: +44 (0)7818 512168 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-...@googlegroups.com. To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
