Sure well +1 for this and we can always add more specific facts. I'll merge for next post Xmas
Paul On Dec 24, 2010 6:09 PM, "Nigel Kersten" <ni...@puppetlabs.com> wrote: > On Fri, Dec 24, 2010 at 12:41 AM, Paul Nasrat <pnas...@gmail.com> wrote: > >> On 24 December 2010 02:52, William Van Hevelingen <wva...@gmail.com> >> wrote: >> > From: William Van Hevelingen <w...@cs.pdx.edu> >> >> Looks good - according to this: >> >> >> http://www.windowsitpro.com/article/tips/jsi-tip-7308-the-windows-xp-and-windows-server-2003-whoami-utility-.aspx >> >> It's new in XP/2003 server. Can someone from puppetlabs let us know >> what the version support for Windows is meant to cover. >> > > There's no need to defer that to Puppet Labs Paul. > > You're setting a lot of the agenda for Facter, you can make decisions like > this. > > Frankly, anything that improves coverage is welcome in my book. > > > > >> >> >> Paul >> >> > Signed-off-by: William Van Hevelingen <wva...@gmail.com> >> > --- >> > Local-branch: feature/master/5666 >> > lib/facter/id.rb | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > diff --git a/lib/facter/id.rb b/lib/facter/id.rb >> > index 0a4067d..deddc4a 100644 >> > --- a/lib/facter/id.rb >> > +++ b/lib/facter/id.rb >> > @@ -1,5 +1,5 @@ >> > Facter.add(:id) do >> > - confine :operatingsystem => %w{Linux Fedora RedHat CentOS SuSE SLES >> Debian Ubuntu Gentoo AIX OEL OVS} >> > + confine :operatingsystem => %w{Linux Fedora RedHat CentOS SuSE SLES >> Debian Ubuntu Gentoo AIX OEL OVS windows} >> > setcode "whoami" >> > end >> > >> > -- >> > 1.7.0.4 >> > >> > -- >> > You received this message because you are subscribed to the Google Groups >> "Puppet Developers" group. >> > To post to this group, send email to puppet-...@googlegroups.com. >> > To unsubscribe from this group, send email to >> puppet-dev+unsubscr...@googlegroups.com<puppet-dev%2bunsubscr...@googlegroups.com> <puppet-dev%2bunsubscr...@googlegroups.com<puppet-dev%252bunsubscr...@googlegroups.com> > >> . >> > For more options, visit this group at >> http://groups.google.com/group/puppet-dev?hl=en. >> > >> > >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Puppet Developers" group. >> To post to this group, send email to puppet-...@googlegroups.com. >> To unsubscribe from this group, send email to >> puppet-dev+unsubscr...@googlegroups.com<puppet-dev%2bunsubscr...@googlegroups.com> <puppet-dev%2bunsubscr...@googlegroups.com<puppet-dev%252bunsubscr...@googlegroups.com> > >> . >> For more options, visit this group at >> http://groups.google.com/group/puppet-dev?hl=en. >> >> > > -- > You received this message because you are subscribed to the Google Groups "Puppet Developers" group. > To post to this group, send email to puppet-...@googlegroups.com. > To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com<puppet-dev%2bunsubscr...@googlegroups.com> . > For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en. > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-...@googlegroups.com. To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
