On Thu, Jan 6, 2011 at 11:43 AM, Daniel Pittman <[email protected]> wrote: > That is a very brief commit message; it would be great to have a > summary, and a full explanation, of the change included so that folks > like me can see why things were being done.
I thought it was a fairly evident commit and felt more explanation would have been rambling. Is it not clear why the inspect app should have audit set to true in its reports? I'm having trouble thinking what I would have put in for a full explanation. Do you need background on what inspect does? > It would also be nice to split out whitespace and functional changes > into two commits, with appropriate notes, so that it is easier to see > what you actually did. :) I also like whitespace changes split out in general, but for such a short commit I didn't think it was very necessary. I figure it would take someone almost as long to read two commits as it would to see what was added in that line that changed. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
